Re-export errors from distutils
#2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in pypa#2698, exposing distutil errors via setuptools help the migration stated by PEP 632.
jaraco
reviewed
Nov 7, 2021
|
Thank you very much for the review and improvements! |
|
Thank you for doing this @abravalheri! |
ods
pushed a commit
to aio-libs/aiokafka
that referenced
this pull request
Dec 31, 2021
* Fix doc building #804 removed the `aiokafka.protocol.produce` stubs imported from `kafka-python`, this caused the documentation to fail to build. * Fix RTD doc compilation #810 imports errors from `setuptools` instead of `distutils` This is available only starting from `setuptools` v59.0.0 (pypa/setuptools#2858) but RTD currently defaults to v58.2.0 (https://docs.readthedocs.io/en/stable/builds.html#python)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As stated in #2698, exposing
distutil.errorsvia thesetuptoolsmodule might facilitate people that want to tackle the migration motivated by PEP 632.These exceptions might appear when customising commands like
build_pyandbuild_ext, and there are examples of projects explicitly checking them in the original issue.This PR re-exports most of these functions via
setuptools.errors.DistutilsGetoptErrorandDistutilsArgErrorare left out, since they are related to the deprecated practice of running thesetup.pyscript directly (I think).I also removed the
"Distutils"part of the name of some exceptions and added notes about the migration/replacements in the docs.Closes #2698
Pull Request Checklist
changelog.d/.(See documentation for details)